Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Solve issue with missing years by retrying #370

Merged
merged 14 commits into from
Dec 8, 2022

Conversation

DenverCoder1
Copy link
Owner

@DenverCoder1 DenverCoder1 commented Dec 1, 2022

Description

Fixes #

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

@DenverCoder1 DenverCoder1 added the bug Something isn't working label Dec 1, 2022
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-fix-solve--ouopxt December 1, 2022 21:25 Inactive
@DenverCoder1 DenverCoder1 force-pushed the fix-Solve-issue-with-missing-years branch from 4d6a1a0 to 2ba8d54 Compare December 1, 2022 21:26
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-fix-solve--ouopxt December 1, 2022 21:26 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-fix-solve--dnrrbe December 4, 2022 06:55 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-fix-solve--m7felg December 4, 2022 07:04 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readme-streak-stats December 4, 2022 07:07 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readme-streak-stats December 4, 2022 07:08 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-fix-solve--14kjnv December 4, 2022 07:08 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readme-streak-stats December 4, 2022 17:26 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-fix-solve--6zgada December 4, 2022 17:26 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-fix-solve--6zgada December 4, 2022 17:27 Inactive
@DenverCoder1 DenverCoder1 force-pushed the fix-Solve-issue-with-missing-years branch from fb03b8a to f0a89af Compare December 6, 2022 20:33
@DenverCoder1 DenverCoder1 temporarily deployed to github-readme-streak-stats December 6, 2022 20:35 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readme-streak-stats December 6, 2022 23:11 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readme-streak-stats December 7, 2022 21:01 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readme-streak-stats December 7, 2022 21:11 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readme-streak-stats December 8, 2022 01:43 Inactive
@DenverCoder1 DenverCoder1 changed the title [WIP] fix: Solve issue with missing years fix: Solve issue with missing years by retrying Dec 8, 2022
@DenverCoder1 DenverCoder1 marked this pull request as ready for review December 8, 2022 01:43
@DenverCoder1 DenverCoder1 merged commit ec87af5 into main Dec 8, 2022
@DenverCoder1 DenverCoder1 deleted the fix-Solve-issue-with-missing-years branch December 8, 2022 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant