Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Persian (fa) translations #382

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

MM25Zamanian
Copy link
Contributor

Description

Defining and adding Persian words

Type of change

  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

@MM25Zamanian
Copy link
Contributor Author

I could not update the README.md file
Because it was a bit mixed

@DenverCoder1 DenverCoder1 added the enhancement New feature or request label Dec 16, 2022
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

image

@DenverCoder1 DenverCoder1 changed the title feat(translations): define persian (fa) words feat: Added Persian (fa) translations Dec 16, 2022
@DenverCoder1 DenverCoder1 merged commit 267ea06 into DenverCoder1:main Dec 16, 2022
@DenverCoder1
Copy link
Owner

I could not update the README.md file Because it was a bit mixed

There's a GitHub workflow that automatically updates the readme, so that's fine

@MM25Zamanian
Copy link
Contributor Author

MM25Zamanian commented Dec 16, 2022

Thanks for merge
But I have a question?
You don't want to install a font for Persian language?

@DenverCoder1
Copy link
Owner

Thanks for merge But I have a question? You don't want to install a font for Persian language?

How does it display for you? It looks fine to me.

For the SVGs, the fonts available are based on what fonts you have on your computer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants