Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Traditional Chinese translation #383

Merged
merged 3 commits into from
Dec 19, 2022
Merged

feat: Added Traditional Chinese translation #383

merged 3 commits into from
Dec 19, 2022

Conversation

xTaiwanPingLord
Copy link
Contributor

Description

  1. Rename "chinese"(zh) to "simplified chinese"(zh-Hans)
  2. Add "traditional chinese"(zh-Hant)

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

@DenverCoder1
Copy link
Owner

DenverCoder1 commented Dec 18, 2022

  • Rename "chinese"(zh) to "simplified chinese"(zh-Hans)

I think rather than renaming, it could be a copy or left as it is.

Renaming is like removing "zh" which would cause it to no longer work if anyone is currently using it.

As a third possibility, a new code adaptation could be made to support locale aliases (eg. a mapping from zh to zh-Hans) so it doesn't have to be duplicated.)

Ideally, locale=zh should do the same thing before as it will after.

If you have other ideas, feel free to suggest.

@DenverCoder1 DenverCoder1 added the enhancement New feature or request label Dec 18, 2022
@xTaiwanPingLord
Copy link
Contributor Author

Renaming is like removing "zh" which would cause it to no longer work if anyone is currently using it.

Oops, I did not notice that :|
I changed zh-Hans back to zh.

@DenverCoder1
Copy link
Owner

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 changed the title Add chinese translation feat: Added Traditional Chinese translation Dec 19, 2022
@DenverCoder1 DenverCoder1 merged commit f86a6bf into DenverCoder1:main Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants