Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround for transparent background in PNG mode #453

Merged

Conversation

DenverCoder1
Copy link
Owner

@DenverCoder1 DenverCoder1 commented Feb 15, 2023

Description

Allows background and stroke colors specified as "#xxxxxx00" or "#xxx0" format to appear transparent instead of black when type is set to PNG. Setting the color to "transparent" works as well.

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-fix-workar-joxmix February 15, 2023 04:32 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-fix-workar-joxmix February 15, 2023 04:32 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-fix-workar-qavejl February 15, 2023 04:40 Inactive
@DenverCoder1 DenverCoder1 merged commit b62b125 into main Feb 15, 2023
@DenverCoder1 DenverCoder1 deleted the fix-workaround-for-transparent-backgrounds-in-PNG-mode branch February 15, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant