Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(demo): add png/json preview to demo site and refactor #457

Merged
merged 5 commits into from
Feb 18, 2023

Conversation

DenverCoder1
Copy link
Owner

Description

  • Added version timestamps to css/js files to avoid old cached versions
  • Removed disable_animations from demo site and replace with "type"
  • Added previewing png and json types
  • Refactored class names
  • Remove global click event listener and run update when picker changed instead

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-refactor-d-etbng2 February 16, 2023 01:15 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-refactor-d-cf0y26 February 16, 2023 01:16 Inactive
@DenverCoder1 DenverCoder1 merged commit adaadc6 into main Feb 18, 2023
@DenverCoder1 DenverCoder1 deleted the refactor-demo branch February 18, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant