Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added rising-sun theme #459

Merged
merged 3 commits into from
Feb 27, 2023
Merged

Conversation

md-rehman
Copy link
Contributor

A minimalist orange theme

A minimalist orange theme
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-patch-1-lbimbzdqu February 21, 2023 14:30 Inactive
@DenverCoder1
Copy link
Owner

The theme looks good, although I do think it looks a bit similar to standard dark theme, but that's okay.

If you could also add an image of the theme to the docs (docs/themes.md), that would be great 👍

Here's a preview url that can be used for the docs - https://user-images.githubusercontent.com/20955511/221126697-2c47639d-23c5-4c23-b545-d883063deebf.png

Let me know if you have any questions 👍

@DenverCoder1 DenverCoder1 added the new theme adding a new theme label Feb 27, 2023
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: Docs have been added and made a small styling change.

The theme looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 changed the title Added rising-sun theme feat: Added rising-sun theme Feb 27, 2023
@DenverCoder1 DenverCoder1 merged commit 6eb655d into DenverCoder1:main Feb 27, 2023
@md-rehman
Copy link
Contributor Author

Thanks, @DenverCoder1 for updating the docs and merging, and I am glad you like it. 😄
And sorry for not replying and an incomplete PR. 😣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new theme adding a new theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants