Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Armenian translations #479

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Conversation

benzlokzik
Copy link
Contributor

@benzlokzik benzlokzik commented Mar 26, 2023

Description

Fixes #

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

streak-stats

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for contributing!

With these suggestions below, the text fits a bit better, I'm happy to hear what you think. Feel free to commit the suggestions using the buttons if you agree with the suggestions.

Before After
image image
image image

src/translations.php Outdated Show resolved Hide resolved
src/translations.php Outdated Show resolved Hide resolved
benzlokzik and others added 2 commits March 28, 2023 01:09
Co-authored-by: Jonah Lawrence <jonah@freshidea.com>
"Present" => "Այժմ"
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 changed the title added Armenian translations feat: Added Armenian translations Mar 28, 2023
@DenverCoder1 DenverCoder1 merged commit f907320 into DenverCoder1:main Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants