Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for excluding days of the week from the streak #490

Merged
merged 16 commits into from
Apr 17, 2023

Conversation

DenverCoder1
Copy link
Owner

@DenverCoder1 DenverCoder1 commented Apr 17, 2023

Description

Resolves #408

https://github-readm-feat-exclu-fo41zs.herokuapp.com/demo/

Usage: &exclude_days=Sun,Sat

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

image

image

Note Translations will be required for the word "Excluding"

image

@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-feat-exclu-y4oh37 April 17, 2023 14:16 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-feat-exclu-y4oh37 April 17, 2023 14:17 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-feat-exclu-cjabry April 17, 2023 14:20 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-feat-exclu-jzxcak April 17, 2023 14:21 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-feat-exclu-meca8s April 17, 2023 14:42 Inactive
@DenverCoder1 DenverCoder1 requested a deployment to github-readm-feat-exclu-jzxcak April 17, 2023 14:42 Abandoned
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-feat-exclu-meca8s April 17, 2023 14:43 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-feat-exclu-croc26 April 17, 2023 16:25 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-feat-exclu-fo41zs April 17, 2023 16:43 Inactive
@DenverCoder1 DenverCoder1 merged commit 622d48e into main Apr 17, 2023
@DenverCoder1 DenverCoder1 deleted the feat/exclude_days branch April 17, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Exclude weekends?
1 participant