Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added option to override starting year for contributions #507

Merged

Conversation

chrisK824
Copy link
Contributor

@chrisK824 chrisK824 commented Apr 23, 2023

Description

Added argument for override minimum year in API request
Added parameter (default as null) to override the minimum year where contributions should count from

Fixes #503

Type of change

  • New feature (added a non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

…ters (default as null) to override the minimum year where contributions should count from
@chrisK824
Copy link
Contributor Author

chrisK824 commented Apr 23, 2023

Hey @DenverCoder1 , I think that little addition is working just fine :)
Tested locally with my account for the new feature.
image

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for working on the issue, I have added a few comments. Feel free to let me know if you have any questions.

.idea/.gitignore Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/index.php Outdated Show resolved Hide resolved
src/stats.php Outdated Show resolved Hide resolved
src/stats.php Outdated Show resolved Hide resolved
src/stats.php Outdated Show resolved Hide resolved
src/index.php Outdated Show resolved Hide resolved
Co-authored-by: Jonah jonah@freshidea.com
@chrisK824
Copy link
Contributor Author

Thanks for the feedback @DenverCoder1 , I applied the changes you suggested :)

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple really small things and I think this is good to merge 👍

(feel free to use the "commit suggestions" buttons on the GitHub UI)

README.md Outdated Show resolved Hide resolved
src/stats.php Outdated Show resolved Hide resolved
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 changed the title Added override minimum starting year for contributions feat: Added option to override starting year for contributions Apr 23, 2023
@DenverCoder1 DenverCoder1 merged commit fb24da9 into DenverCoder1:main Apr 23, 2023
@chrisK824 chrisK824 deleted the override_minimum_contribution_year branch September 22, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributions are not counting all the way back to first contributions
2 participants