-
-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added option to override starting year for contributions #507
feat: Added option to override starting year for contributions #507
Conversation
…ters (default as null) to override the minimum year where contributions should count from
Hey @DenverCoder1 , I think that little addition is working just fine :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for working on the issue, I have added a few comments. Feel free to let me know if you have any questions.
Co-authored-by: Jonah jonah@freshidea.com
Thanks for the feedback @DenverCoder1 , I applied the changes you suggested :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple really small things and I think this is good to merge 👍
(feel free to use the "commit suggestions" buttons on the GitHub UI)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for the contribution 🎉
Description
Added argument for override minimum year in API request
Added parameter (default as null) to override the minimum year where contributions should count from
Fixes #503
Type of change
How Has This Been Tested?
composer test
Checklist: