Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Amharic Translations #511

Merged
merged 4 commits into from
Apr 26, 2023
Merged

feat: Added Amharic Translations #511

merged 4 commits into from
Apr 26, 2023

Conversation

hmhard
Copy link
Contributor

@hmhard hmhard commented Apr 25, 2023

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

Only change is that it should be moved higher up to be in alphabetical order (above Arabic)

Also this is only 86% complete, if possible, you could also add a translation for the word "Excluding" (for example, in the phrase "Excluding Sunday, Saturday")

@DenverCoder1
Copy link
Owner

Thanks 👍

@DenverCoder1 DenverCoder1 changed the title Added Ethiopian Translation feat: Added Amharic Translations Apr 26, 2023
@DenverCoder1 DenverCoder1 merged commit 85c4b5b into DenverCoder1:main Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants