Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Add color customization for excludeDaysLabel #526

Merged
merged 4 commits into from
May 29, 2023

Conversation

DenverCoder1
Copy link
Owner

@DenverCoder1 DenverCoder1 commented May 28, 2023

Description

Fixes #525

Breaking Change Notice

Previously the dates color was used for the excluded days label. Those who override the dates color with the dates query parameter will need to also add excludeDaysLabel with the same value. Use of theme names is not affected.

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

image

@DenverCoder1 DenverCoder1 added the enhancement New feature or request label May 28, 2023
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-feat-exclu-lbhtuh May 28, 2023 23:30 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-feat-exclu-hzylis May 29, 2023 00:35 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-feat-exclu-hzylis May 29, 2023 00:36 Inactive
@DenverCoder1 DenverCoder1 temporarily deployed to github-readm-feat-exclu-lrht6z May 29, 2023 00:40 Inactive
@DenverCoder1 DenverCoder1 changed the title Add color customization for excludeDaysLabel feat!: Add color customization for excludeDaysLabel May 29, 2023
@DenverCoder1 DenverCoder1 merged commit 2d9d196 into main May 29, 2023
@DenverCoder1 DenverCoder1 deleted the feat/excludeDaysLabel-color branch May 29, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add color change of excluded days
1 participant