Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Brazilian Portuguese translations #527

Merged

Conversation

propilideno
Copy link
Contributor

@propilideno propilideno commented Jun 2, 2023

Description

  • Shortened and more accurate brazilian translation from Total Contributions;
  • Excluding translation - Was translated as Except

Why?

Total de Contribuições is correct but i think Contribuições Totais is way better because it removes preposition de.

Excluding in this context is with meaning of Except in pt-BR. So the accurate way to translate Excluding is Exceto.

Type of change

  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@DenverCoder1
Copy link
Owner

Thanks for contributing!

The translation looks great 👍

Brazilian description in capitalized form

Unfortunately, this won't change anything since the table in the readme is automatically generated using translation-progress.php, specifically line 37 which determines the locale name using the PHP internationalization library:

$locale_name = Locale::getDisplayName($locale, $locale);

So if this is merged, the script will just run again and change it back.

@propilideno
Copy link
Contributor Author

propilideno commented Jun 2, 2023

Got it, i don't know php, just tried to fuzzy find pt_BR to fix it.
Btw, looks 100% supported pt_BR for me. I can change it to 100% and undo capitalized form.

@DenverCoder1
Copy link
Owner

Btw, looks 100% supported pt_BR for me. I can change it to 100% and undo capitalized form

The phrase that's missing from the Portuguese is the word "Excluding" as shown below:

image

Once that is added, it will be at 100%. If you want to add that, that would be great 👍

You don't need to modify the readme at all by the way. Once it's merged, the GitHub actions bot will update the readme automatically.

@propilideno
Copy link
Contributor Author

propilideno commented Jun 3, 2023

Ok, i got it now, thank you Jonah!
Usually in PT_BR when we want to exclude something, we commonly say Except.

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 changed the title Fix brazilian translation feat: Update Brazilian Portuguese translations Jun 4, 2023
@DenverCoder1 DenverCoder1 merged commit a51c898 into DenverCoder1:main Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants