Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): Improvements to Vercel deployment instructions #534

Merged
merged 2 commits into from
Aug 31, 2023

Conversation

DmGsOuNaK
Copy link
Contributor

@DmGsOuNaK DmGsOuNaK commented Jun 19, 2023

Description

Fixes #

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

@tranthaituananh
Copy link
Contributor

@DenverCoder1 reviews it and I am having some difficulty, can you provide a quick way to contact you?

@DenverCoder1 DenverCoder1 added the documentation Improvements or additions to documentation label Aug 31, 2023
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! 👍

Sorry for the delay in getting this review in. In the future, I recommend adding a detailed PR title and description that makes it clear what the purpose of the PR is. In general, it's best to avoid changing things that are not necessary to be changed but some of the changes you made I agree with. I hope it is fine that I made some adjustments and fixed the spacing.

@DenverCoder1 DenverCoder1 changed the title updated readme.md file docs(readme): Improvements to Vercel deployment instructions Aug 31, 2023
@DenverCoder1 DenverCoder1 merged commit 6ba3ca5 into DenverCoder1:main Aug 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants