Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add alt optional copy HTML to clipboard on demo site #608

Merged
merged 3 commits into from
Oct 3, 2023
Merged

feat: Add alt optional copy HTML to clipboard on demo site #608

merged 3 commits into from
Oct 3, 2023

Conversation

R055A
Copy link
Contributor

@R055A R055A commented Oct 2, 2023

Description

Add alternative option for copying HTML to the clipboard on the demo site.

Fixes #572

Type of change

  • New feature (added a non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

light

dark

Haven't included images for entering a valid username, but can verify both Copy to Clipboard buttons enable

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I just have a minor suggestion.

Another thing to consider is maybe making a JSON Endpoint section appear when the type is set to JSON instead of having HTML and Markdown, but that can be saved for another PR if you prefer.

src/demo/js/script.js Outdated Show resolved Hide resolved
@R055A
Copy link
Contributor Author

R055A commented Oct 3, 2023

Looks great, I just have a minor suggestion.

Another thing to consider is maybe making a JSON Endpoint section appear when the type is set to JSON instead of having HTML and Markdown, but that can be saved for another PR if you prefer.

It may be better to make a new PR for the JSON clipboard feature. If you assign me to a new Issue for the JSON clipboard I can make a PR for it by today or tomorrow (depending time zone).

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 merged commit f5aeeca into DenverCoder1:main Oct 3, 2023
2 checks passed
@DenverCoder1 DenverCoder1 changed the title Add alt optional copy HTML to clipboard on demo site feat: Add alt optional copy HTML to clipboard on demo site Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Demo site feature: Add alternate output types on the demo site
2 participants