Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: demo site color property added twice #614

Merged
merged 1 commit into from
Oct 22, 2023

Conversation

davidzr
Copy link
Contributor

@davidzr davidzr commented Oct 21, 2023

Description

Setting the recently removed option as the currently selected one

Fixes #570

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

Usually it's best to comment first if the issue is already assigned to someone, but since there hasn't been any activity in over a month, I think that's fine.

@DenverCoder1 DenverCoder1 merged commit 3711688 into DenverCoder1:main Oct 22, 2023
2 checks passed
@davidzr
Copy link
Contributor Author

davidzr commented Oct 22, 2023

Thanks! I'll keep this in mind for the next time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Demo site: It is sometimes possible to add a color property twice
2 participants