Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Burmese Translation #626

Merged
merged 5 commits into from
Dec 7, 2023

Conversation

LinThitHtwe
Copy link
Contributor

Description

Added Burmese Translation

Fixes #

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • [ ✔️] Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • [✔️ ] I have checked to make sure no other pull requests are open for this issue
  • [ ✔️] The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

@DenverCoder1
Copy link
Owner

Thanks for contributing!

Do you know if there is a difference between regular Burmese and Burmese (Myanmar [Burma]) for these translations? If there is not, we could simply use my instead of my_MM to specify only the language and not the language and the country code.

@LinThitHtwe
Copy link
Contributor Author

LinThitHtwe commented Dec 7, 2023

Thanks for contributing!

Do you know if there is a difference between regular Burmese and Burmese (Myanmar [Burma]) for these translations? If there is not, we could simply use my instead of my_MM to specify only the language and not the language and the country code.

There aren't any difference. "my" can be use instead. Should I take responsibility for making the change, or would you prefer to handle it yourself?

src/translations.php Outdated Show resolved Hide resolved
Co-authored-by: Jonah Lawrence <jonah@freshidea.com>
Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

@DenverCoder1 DenverCoder1 changed the title Added Burmese Translation feat: Added Burmese Translation Dec 7, 2023
@DenverCoder1 DenverCoder1 merged commit 31e1ef1 into DenverCoder1:main Dec 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants