Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added card_height option #673

Merged
merged 9 commits into from
May 5, 2024
Merged

Conversation

hany-z
Copy link
Contributor

@hany-z hany-z commented Apr 26, 2024

feat: create height option

  • Created input for height option in form (src/demo/index.php)
  • Update custom image height in process (src/card.php)

Description

Fixes #659

Type of change

  • Bug fix (added a non-breaking change which fixes an issue)
  • New feature (added a non-breaking change which adds functionality)
  • Updated documentation (updated the readme, templates, or other repo files)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • Tested locally with a valid username
  • Tested locally with an invalid username
  • Ran tests with composer test
  • Added or updated test cases to test new features

Checklist:

  • I have checked to make sure no other pull requests are open for this issue
  • The code is properly formatted and is consistent with the existing code style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Screenshots

image

…(src/demo/index.php) - Update custom image height in process (src/card.php)
@hany-z
Copy link
Contributor Author

hany-z commented Apr 26, 2024

I made a small change that help with this issue.

Copy link
Owner

@DenverCoder1 DenverCoder1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution 🎉

Having the numbers outside the SVG also helps with maintainability, so this is great 👍

@DenverCoder1 DenverCoder1 merged commit 46b4048 into DenverCoder1:main May 5, 2024
4 checks passed
@DenverCoder1 DenverCoder1 changed the title feat: create height option - Created input for height option in form … feat: Added card_height option May 5, 2024
@hany-z
Copy link
Contributor Author

hany-z commented May 6, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Card is slightly higher than github-readme-stats cards.
2 participants