style: Add rounded borders on original comment box #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks good, but I think maybe less rounded would be better. In my opinion, it should ideally match the roundness of the other elements on the page (4px on redesign, 7px on old reddit)
Feel free to use the "Commit suggestion" buttons if you agree and let me know what you think.
|
Oh great point, I didn't think to check what rounding other elements were using, consistent rounding definitely looks much better |
DenverCoder1
approved these changes
Mar 12, 2023
|
Cheers! |
DenverCoder1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds "border-radius: 20px;" to the original comment window on new/old Reddit, this should improve view-ability and make the visual styling slightly more appealing
Sorry if this was an already considered suggestion that was rejected as I couldn't find anything