chore: added swagger types for BOM operations #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerlh
force-pushed
the
chore/fix-swagger-types
branch
2 times, most recently
from
1460574 to
62e426b
Compare
|
Can I suggest to submit a PR with only the changes you propose? Currently 90% seems to be only linting? |
omerlh
force-pushed
the
chore/fix-swagger-types
branch
from
62e426b to
c6935b3
Compare
|
Yes, sorry - fixed. VS code did things I didn't noticed... |
omerlh
force-pushed
the
chore/fix-swagger-types
branch
5 times, most recently
from
acb2291 to
edad8fb
Compare
|
You'll find lots of these inconsistencies, which is why I can't really recommend generating clients from the swagger doc. See #840. |
|
I don't mind keep fixing it as I'm going, I have a client that works pretty well and generated from Swagger. If this is acceptable by you, OFC... |
nscuro
requested changes
Dec 5, 2022
src/main/java/org/dependencytrack/resources/v1/vo/BomUploadResponse.java
Outdated
Show resolved
Hide resolved
omerlh
force-pushed
the
chore/fix-swagger-types
branch
from
edad8fb to
966c3c1
Compare
|
I think the build failure are not related to my changes |
Signed-off-by: Omer Levi Hevroni <omer@goledge.com>
omerlh
force-pushed
the
chore/fix-swagger-types
branch
from
966c3c1 to
90a2356
Compare
|
Ok, rebased |
nscuro
approved these changes
Dec 6, 2022
mulder999
pushed a commit
to mulder999/dependency-track
that referenced
this pull request
Dec 23, 2022
Signed-off-by: Omer Levi Hevroni <omer@goledge.com> Signed-off-by: Omer Levi Hevroni <omer@goledge.com> Signed-off-by: mulder999 <nospam099-github@yahoo.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I was working on generating a typescript client using Swagger (happy to contribute the client also!) and I noticed some APIs does not have well defined responses.
Addressed Issue
Additional Details
Checklist
I am not sure how I should test it, so happy to get some feedback on the change!