-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidated Dependency Updates (Take2) #2832
Conversation
@nscuro not sure why DCO is failing if i did signoff on all my commits. 😿 they all say |
I think the problem is the email address in the sign-off: https://github.com/DependencyTrack/dependency-track/pull/2832/checks?check_run_id=14392050786 |
Unfortunately, if you look at the other commits (which are passing) they all say Signed-off-by: Melba Lopez Melba.Lopez@ibm.com Passing: Interestingly enough, only Reverting Jekyll shows a red x and that its not passing. So why do the logs show 2 but only 1 gets flagged? and why are they even getting flagged if every commit says the same thing for signoff. 😞 |
@melba-lopez, this might be a red herring (because some of your commits were fine) but just checking... Is this what is configured as your primary email account in GitHub? That is what DCO expects. The first time I tried to use DCO I used my secondary email. The sig was otherwise 100% correctly formatted... and DCO failed. Most annoying. |
@melba-lopez Stupid question, but did you sign-off "manually" via commit message, or did you use the |
Maybe just rebase and/or squash and sign the new commit(s)? |
Good call. Likely best way forward here :D |
See https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/ Signed-off-by: nscuro <nscuro@protonmail.com> Signed-off-by: Melba Lopez <Melba.Lopez@ibm.com>
Includes stevespringett/Alpine#494 among other changes so far. Also added documentation for `alpine.datanucleus.cache.level2.type`. Signed-off-by: nscuro <nscuro@protonmail.com> Signed-off-by: Melba Lopez <Melba.Lopez@ibm.com>
Consolidated dependency updates | Package | Type | Update | Change | |---|---|---|---| |org.glassfish.jaxb:jaxb-runtime (source) | compile | patch | 2.3.6 -> 2.3.8 | |com.microsoft.sqlserver:mssql-jdbc | compile | major | 11.2.3.jre17 -> 12.2.0.jre11 | |mysql:mysql-connector-java | compile | patch | 8.0.29 -> 8.0.33 | |org.postgresql:postgresql (source) | compile | minor | 42.5.1 -> 42.6.0 | |org.eclipse.jetty:jetty-maven-plugin (source) | build | major | 10.0.15 -> 11.0.15 | - [x ] This PR fixes a defect, and I have provided tests to verify that the fix is effective Signed-off-by: Melba Lopez <Melba.Lopez@ibm.com>
|eclipse-temurin | stage | patch | 17.0.6_10-jre-focal -> 17.0.7_7-jre-focal | DependencyTrack#77 | Signed-off-by: Melba Lopez <Melba.Lopez@ibm.com>
|jekyll | | major | '~> 3.8' -> '~> 4.0' | Signed-off-by: Melba Lopez <Melba.Lopez@ibm.com>
Signed-off-by: Melba Lopez <Melba.Lopez@ibm.com>
it seems to be because the last 2 i signed off via the UI versus command line sigh DCO is passing now |
Description
ORIGINAL PR #2725
Consolidated dependency updates
mysql:mysql-connector-java '8.0.29 -> 8.0.33 'jekyll '3.8 -> 4.0 'org.eclipse.jetty:jetty-maven-plugin (source) '10.0.15 -> 11.0.15 'Addressed Issue
Additional Details
Upgrades not compatible at this time:
Postponed:
Checklist