Support customizable welcome message to display on login page #4131
+77
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gepardgame
force-pushed
the
feat/customizable-login-page
branch
2 times, most recently
from
2f6516f to
f91c8b5
Compare
Added new configProperty return and new configProperty Signed-off-by: Thomas Schauer-Köckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Gepardgame
force-pushed
the
feat/customizable-login-page
branch
from
f91c8b5 to
4a1ebc3
Compare
Signed-off-by: Thomas Schauer-Köckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
nscuro
requested changes
Sep 10, 2024
src/main/java/org/dependencytrack/model/ConfigPropertyConstants.java
Outdated
Show resolved
Hide resolved
src/main/java/org/dependencytrack/resources/v1/ConfigPropertyResource.java
Outdated
Show resolved
Hide resolved
that only return if the prop is marked public Signed-off-by: Thomas Schauer-Köckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
nscuro
reviewed
Sep 10, 2024
src/main/java/org/dependencytrack/resources/v1/ConfigPropertyResource.java
Outdated
Show resolved
Hide resolved
src/test/java/org/dependencytrack/resources/v1/ConfigPropertyResourceTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Thomas Schauer-Köckeis <thomas.schauer-koeckeis@rohde-schwarz.com>
2 tasks
nscuro
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an API Endpoint, open to anyone, that only can return the custom welcome message given by admins.
Adds 2 ConfigProperties to store the message and if it should be shown.
Addressed Issue
Fixes #863
Additional Details
Checklist
- [ ] This PR fixes a defect, and I have provided tests to verify that the fix is effective- [ ] This PR introduces changes to the database model, and I have added corresponding update logic- [ ] This PR introduces new or alters existing behavior, and I have updated the documentation accordingly