Fix infinite recursion during policy condition serialization #4165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of Alpine v3, objects are no longer unloaded and refreshed (with fetch groups) during `QueryManager#persist`. In case of the `PolicyCondition` REST endpoints, the previous behavior caused `PolicyCondition#policy` to be unloaded, prior to serializing the `PolicyCondition` response. With persistent objects no longer being unloaded and refreshed in `QueryManager#persist`, that behavior changed, leading to infinite recursion when serializing `PolicyCondition#policy`. Resolved the issue by restoring the previous behavior of not returning policy data in any of the condition endpoints. Signed-off-by: nscuro <nscuro@protonmail.com>
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
nscuro
added a commit
to DependencyTrack/hyades-apiserver
that referenced
this pull request
Sep 22, 2024
Ports DependencyTrack/dependency-track#4165 from Dependency-Track v4.12.0 Signed-off-by: nscuro <nscuro@protonmail.com>
This was referenced Sep 22, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes infinite recursion during policy condition serialization.
Addressed Issue
N/A
Additional Details
As of Alpine v3, objects are no longer unloaded and refreshed (with fetch groups) during
QueryManager#persist.In case of the
PolicyConditionREST endpoints, the previous behavior causedPolicyCondition#policyto be unloaded, prior to serializing thePolicyConditionresponse.With persistent objects no longer being unloaded and refreshed in
QueryManager#persist, that behavior changed, leading to infinite recursion when serializingPolicyCondition#policy.Resolved the issue by restoring the previous behavior of not returning policy data in any of the condition endpoints.
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly