Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix policy evaluation not happening upon creation or update of individual components #4374

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

fupgang
Copy link
Contributor

@fupgang fupgang commented Nov 13, 2024

Description

Fixes #4373 as suggested in the issue.

Addressed Issue

#4373

Additional Details

The test PolicyEvaluationTaskTest does not exactly check the fix.
But I found it valuable since there seems to be no test case yet for PolicyEvaluationTask. I used it to study the behavior, it asserts another aspect.

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Signed-off-by: fupgang <75629871+fupgang@users.noreply.github.com>
Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.08% (target: -1.00%) 100.00% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (3c265ed) 22579 17852 79.06%
Head commit (dc48389) 22579 (+0) 17871 (+19) 79.15% (+0.08%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4374) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@nscuro nscuro changed the title fixes #4373 Fix policy evaluation not happening upon creation or update of individual components Nov 13, 2024
@nscuro nscuro added the defect Something isn't working label Nov 13, 2024
@nscuro nscuro added this to the 4.13 milestone Nov 13, 2024
@nscuro nscuro added the backport/4.12.2 PRs to be backported to version 4.12.2 label Nov 13, 2024
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, and thanks for the fix!

@nscuro nscuro merged commit 4a59915 into DependencyTrack:master Nov 13, 2024
11 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/4.12.2 PRs to be backported to version 4.12.2 defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Creating or updating a component should trigger a policy evaluation but does not
2 participants