Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate MirrorVulnerabilityProcessor from Kafka Streams to Parallel Consumer #553

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Feb 5, 2024

Description

Migrates MirrorVulnerabilityProcessor from Kafka Streams to Parallel Consumer.

Warning

Depends on #552, please review and merge that first!

Addressed Issue

Relates to DependencyTrack/hyades#346
Relates to DependencyTrack/hyades#901
Relates to DependencyTrack/hyades#907

Additional Details

The processor defaults to ordering mode partition with a max concurrency matching the number of input partitions.

Ordering mode partition enables head-of-line blocking semantics, meaning the processor will continue retrying failing records instead of dropping them and proceeding to consume more.

This behavior is desirable because the dtrack.vulnerability topic is compacted, and records are never re-published unless the respective vulnerability has changed.

Checklist

  • I have read and understand the contributing guidelines
  • This PR fixes a defect, and I have provided tests to verify that the fix is effective
  • This PR implements an enhancement, and I have provided tests to verify that it works as intended
  • This PR introduces changes to the database model, and I have added corresponding update logic
  • This PR introduces new or alters existing behavior, and I have updated the documentation accordingly

Copy link

codacy-production bot commented Mar 4, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.01% (target: -1.00%) 83.33% (target: 70.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (1725d35) 18711 14568 77.86%
Head commit (4aa68ef) 18700 (-11) 14558 (-10) 77.85% (-0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#553) 6 5 83.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

… Consumer

Depends on #552

Relates to DependencyTrack/hyades#346
Relates to DependencyTrack/hyades#901
Relates to DependencyTrack/hyades#907

Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro merged commit 8ff235b into main Mar 22, 2024
10 checks passed
@nscuro nscuro deleted the issue-907-2 branch March 22, 2024 14:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants