Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set configuration for index properly. run collection benchmark #24

Merged
merged 1 commit into from
May 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 35 additions & 11 deletions benchmarks/bench_lintdb.py
Original file line number Diff line number Diff line change
@@ -1,21 +1,12 @@
import lintdb as ldb
from datasets import load_dataset
from collections import namedtuple
from colbert import Indexer, Searcher
from colbert.infra import Run, RunConfig, ColBERTConfig
from colbert.data import Queries, Collection
import os
import sys
import jsonlines
from collections import defaultdict
from tqdm import tqdm

import time
import numpy as np
import typer
import random
import tempfile
from typing import List, Annotated
from common import get_memory_usage
from lotte.common import _evaluate_dataset, load_lotte

try:
from valgrind import callgrind_start_instrumentation, callgrind_stop_instrumentation, callgrind_dump_stats
Expand Down Expand Up @@ -81,6 +72,39 @@ def single_search(dataset:str='lifestyle', split:str='dev',profile=False, checkp
print(f"95th percentile memory usage: {np.percentile(memory, 95):.2f}MB")
print(f"99th percentile memory usage: {np.percentile(memory, 99):.2f}MB")


@app.command()
def collection(dataset:str='lifestyle', split:str='dev',profile=False, checkpoint:str='colbert-ir/colbertv2.0', index_path:str='experiments/py_index_bench_colbert-lifestyle-2024-04-03'):
latencies = []
memory = []

with tempfile.TemporaryDirectory(prefix="lintdb_bench_collection") as dir_one:
index = ldb.IndexIVF(index_path, 32768, 128, 2, 6, 16, ldb.IndexEncoding_BINARIZER)
opts = ldb.CollectionOptions()
opts.model_file = 'assets/model.onnx'
opts.tokenizer_file = 'assets/colbert_tokenizer.json'
collection = ldb.Collection(index, opts)
collection.train(['hello world!'] * 35000)
rankings = {}

count=0
for id in range(1000):

start = time.perf_counter()
collection.add(0, id, "hello world!", {"title": "metadata"})
latencies.append((time.perf_counter() - start)*1000)

memory.append(get_memory_usage())

if count == 212:
break


print(f"Average add latency: {np.mean(latencies):.2f}ms")
print(f"Median add latency: {np.median(latencies):.2f}ms")
print(f"95th percentile add latency: {np.percentile(latencies, 95):.2f}ms")
print(f"99th percentile add latency: {np.percentile(latencies, 99):.2f}ms")


if __name__ == "__main__":
app()
13 changes: 9 additions & 4 deletions lintdb/index.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -58,14 +58,19 @@

IndexIVF::IndexIVF(std::string path, Configuration& config)
: config(config), path(path) {
IndexIVF(
path,
LINTDB_THROW_IF_NOT(config.nlist <= std::numeric_limits<code_t>::max());

this->config = config;

this->encoder = std::make_unique<DefaultEncoder>(
config.nlist,
config.dim,
config.nbits,
config.niter,
config.nlist,
config.dim,
config.num_subquantizers,
config.quantizer_type);

initialize_inverted_list(config.lintdb_version);
}

IndexIVF::IndexIVF(
Expand Down Expand Up @@ -259,7 +264,7 @@
// result: (num_tokens x nlist)
gsl::span<const float> query_span = gsl::span(data, n);
RetrieverOptions plaid_options = RetrieverOptions{
.total_centroids_to_calculate = config.nlist,

Check warning on line 267 in lintdb/index.cpp

View workflow job for this annotation

GitHub Actions / Run Cmake

designated initializers are a C++20 extension [-Wc++20-designator]
.num_second_pass = opts.num_second_pass,
.expected_id = opts.expected_id,
.centroid_threshold = opts.centroid_score_threshold,
Expand Down
Loading