Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added favorite management using Telegram #386

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Conversation

floriegl
Copy link
Contributor

@floriegl floriegl commented Jul 2, 2023

Pull Request Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Did you make your Pull Request on the dev branch?
  • Does your submission pass tests? make test
  • Have you lint your code locally prior to submission? make lint
  • Could you build and run the docker image successfully? make image
  • Could you create a running executable? make executable
  • Have you added an explanation of what your changes do and why you'd like to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully ran manual tests with your changes locally?

@floriegl floriegl changed the base branch from main to dev July 2, 2023 22:04
@floriegl
Copy link
Contributor Author

floriegl commented Jul 3, 2023

This MR adds /listfavorites (to list all favorites), /listfavoriteids (to list all ids of the favorites), /addfavorites (to add item ids to favorites), /removefavorites (to remove item ids from favorites) and the possibility to change the favorite status of an item by sending the link to the bot.

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 48.45% and project coverage change: -0.54% ⚠️

Comparison is base (8b6ea89) 57.85% compared to head (0030ca9) 57.32%.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #386      +/-   ##
==========================================
- Coverage   57.85%   57.32%   -0.54%     
==========================================
  Files          25       26       +1     
  Lines        1801     1891      +90     
==========================================
+ Hits         1042     1084      +42     
- Misses        759      807      +48     
Files Changed Coverage Δ
src/scanner.py 0.00% <0.00%> (ø)
src/notifiers/telegram.py 16.37% <14.54%> (-1.50%) ⬇️
src/models/__init__.py 100.00% <100.00%> (ø)
src/models/favorites.py 100.00% <100.00%> (ø)
src/notifiers/notifiers.py 48.97% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants