Fix support for include paths #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this, the sass4clj CLI or using sass4clj as a Git dep failed
with this error:
Syntax error (ClassNotFoundException) compiling at (sass4clj/core.clj:1:1).
io.bit3.jsass.Sass2ScssOptions
Presumably because this fix wasn't included in jsass 5.5.2, which is
what deps.edn used prior to this commit.
Previously, :source-paths were dissoc'ed from the options map, in sass4clj.api call sites, preventing them from being added into the include paths.
I think consumers should be able to pick their own slf4j implementation.
|
i have the same problem and just recognized that it seems to be fixed here :). Is there a reason behind why the fix didnt find the way into a release yet? |
|
Released in 0.7.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to install Bulma via NPM, add
node_modulesinto:source-pathsand include the Bulma SASS files in my project SCSS files, but that didn't work. Turns out that was because when calling via thesass4clj.apinamespace,:source-pathswere getting removed from theoptionsmap and not getting added into include paths.I also made a couple of changes that make it easier to use sass4clj as a Git dependency. Two issues remain there: sass4clj has a kind of an implicit dependency to both Component and Integrant, but neither are included in
deps.edn. They're marked as test dependencies inbuild.boot, which is a bit odd — should they be:providedinstead?