#15 Feature flag CodeLens integration, don't combine globs that use group conditions #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbridge
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where VSCode didn't allow nested group conditions in globs such as
{**/*{nunit,xunit}.dll,**/node_modules/**}. This often occurred when we tried to combine globs together for efficiency.We now use a optimisation strategy where we always loop round multiple search patterns, but will optionally condense the number of individual search patterns if group conditions aren't used. This optimisation can be improved in the future.
We also combine config watching logic into the ConfigManager and only use one instance of the config manager across the codebase. This allows easy watching across the codebase as well as disposal of watchers.