Reduced likely hood of race conditions when unmanaged windows still h…

…ave properties to be updated (#458)
DerjenigeUberMensch · Oct 13, 2024 · dd568d1 · dd568d1
1 parent 417759f
commit dd568d1
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/src/prop.c b/src/prop.c
@@ -685,15 +685,25 @@ PropUpdateProperty(
     const enum PropertyType type = cookie->type;
     const XCBWindow win = cookie->win;
     const u8 validtype = PropValidType(type);
+    u8 valid_client;
 
     if(validtype)
     {
         cookie->cookie.sequence = 0;
         if(__prophandler__[type].get_cookie)
         {   cookie->cookie = __prophandler__[type].get_cookie(display, win);
         }
-        if(__prophandler__[type].get_reply)
-        {   __prophandler__[type].get_reply(display, cookie);
+        LockMainThread();
+        valid_client = cookie->cookie.sequence == 0 || wintoclient(win);
+        UnlockMainThread();
+        if(valid_client)
+        {
+            if(__prophandler__[type].get_reply)
+            {   __prophandler__[type].get_reply(display, cookie);
+            }
+        }
+        else
+        {   XCBDiscardReply(display, cookie->cookie);
         }
     }
 }