Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Clients not maximizing when should maximize for floating windows #450

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Fixed Clients not maximizing when should maximize for floating windows #450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 8 additions & 28 deletions src/client.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,11 +218,11 @@ enum FloatType COULDBEFLOATINGHINTS(Client *c)
else if(ISNORMAL(c))
{
Debug0("Normal Window detected.");
return CouldBeFloating;
return ProbablyNotFloating;
}
Debug0("Window has no special attributes.");
/* No special attributes return */
return CouldBeFloating;
return ProbablyNotFloating;
}

static bool
Expand Down Expand Up @@ -528,7 +528,6 @@ __FLOAT__TYPE__IS__FLOATING(
}
break;
}

case DefinitelyNotFloating:
{
switch(geom)
Expand Down Expand Up @@ -621,47 +620,28 @@ __FLOAT__TYPE__IS__FLOATING(
}
const Monitor *m = c->desktop->mon;
Debug("Float state: %d", ret);
/* UNUSED DUE TO unreliablity.
switch(ret)
{
case DefinitelyFloating:
if(geom == DefinitelyNotFloating)
{
/* check if in the corner */
if(c->x == m->mx && c->y == m->my)
{ ret = DefinitelyNotFloating;
}
}
break;
case ProbablyFloating:
if(geom == DefinitelyNotFloating || geom == ProbablyNotFloating)
{
/* check if in the corner */
if(c->x == m->mx && c->y == m->my)
{ ret = DefinitelyNotFloating;
}
}
break;
case CouldBeFloating:
if(geom != DefinitelyFloating && geom != ProbablyFloating)
{ /* check if in the corner */
if(c->x == m->mx && c->y == m->my)
{ ret = DefinitelyNotFloating;
}
}
break;
case ProbablyNotFloating:
/* check if in the corner */
if(c->x == m->mx && c->y == m->my)
{ ret = DefinitelyNotFloating;
}
break;
case DefinitelyNotFloating:
break;

case FLOATINGLAST:
default:
break;
}
*/
/* check if in the corner */
if(c->x == m->mx && c->y == m->my)
{ ret = DefinitelyNotFloating;
}
Debug("Is float: %s", ret != DefinitelyNotFloating ? "true" : "false");
return ret != DefinitelyNotFloating;
}
Expand Down