Add pills for more Loadout Analysis / Warnings / Upgrade possibilities #10012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robojumper
force-pushed
the
loadout-analysis
branch
2 times, most recently
from
52cc1c1
to
a4d6435
Compare
bhollis
approved these changes
Oct 31, 2023
| } { | ||
| autoStatMods: boolean, | ||
| /** If set, only sets where at least one stat **exceeds** `resolvedStatConstraints` minimums will be returned */ | ||
| strictUpgrades: boolean, |
There was a problem hiding this comment.
I see where you're going with this, and I love it!
| @@ -60,7 +64,12 @@ export default function LoadoutsContainer({ account }: { account: DestinyAccount | |||
| return <ShowPageLoading message={t('Loading.Profile')} />; | |||
| } | |||
|
|
|||
| return <Loadouts account={account} />; | |||
| // TODO: how high in our tree do we want this analyzer? | |||
There was a problem hiding this comment.
This seems fine, though if you moved it down into Loadouts I bet you could directly assign selectedStoreId as a prop rather than having to use useUpdateLoadoutAnalysisContext.
There was a problem hiding this comment.
I actually did that first but ran into the issue that the useSummaryLoadoutsAnalysis hook also needs to exist in Loadouts and that one needs the context outside of it.
There's also a case to be made for placing it even higher in the tree (around our routes) since right now navigating away from the Loadouts page cleans up the analyzer and discards all results.
bhollis
reviewed
Oct 31, 2023
Co-authored-by: Ben Hollis <ben@benhollis.net>
robojumper
force-pushed
the
loadout-analysis
branch
from
20b52d6
to
56eddb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goals:
I previously did something similar in #9566 but it did not work well across components and abused React for task scheduling. This one uses a bit of a custom task queue for submitting loadouts for analysis, caching the results, and getting results asynchronously using
React.useSyncExternalStore.This custom task queue prioritizes analysis requests and will ensure that loadouts the user is looking at (which works because of loadouts list virtualization) are analysed first, and everything else is analyzed in the background.