Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in the displayed calculated loadout power #10546

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

dghost
Copy link
Contributor

@dghost dghost commented Jun 14, 2024

The calculated loadout power displayed in the UI was using all weapons + armor in a loadout to calculate the power level, which could lead to incorrect results when applied in-game. This change filters the items used in the power level calculation down to just equipped weapons and armor, so that it (hopefully) matches the in-game value after it has been applied.

This should resolve #10527.

Copy link
Contributor

@bhollis bhollis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@bhollis bhollis merged commit e965d5e into DestinyItemManager:master Jun 14, 2024
6 checks passed
@bhollis
Copy link
Contributor

bhollis commented Jun 14, 2024

FYI e88b109

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Light level calculation of loadouts includes light level of non-equipped weapons and armor
2 participants