-
-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better display for exotic class item perks, remove stats from class items in itemfeed #10557
Conversation
In the meantime please let me know of any esoteric cases I should test for this. |
It seems like the isReusable hack can be omitted if https://github.com/DestinyItemManager/DIM/tree/archetype-presstip goes in, though I'm not sure which solution is the right one to go for. |
Do class items really need stat display on the item feed? |
Nope |
@robojumper you've got the most experience with the socket stuff - would love your opinion on this. |
I've swapped the contents of master...FlaminSarge:DIM:exoticclass2 and master...FlaminSarge:DIM:exoticclass as the other implementation is much cleaner and doesn't touch nearly as many places due to omitting the 'multiple intrinsics' change. UI remains consistent with the other, and we don't run into the issues associated with changing intrinsicSocket -> intrinsicSockets. |
…perks on item feed Remove stats from class items in item feed
move extra intrinsic parsing to util method fix casting/filtering make intrinsic socket handling allow multiple plugOptions for armor to align it with weapon impl, just in case
Makes exotic class items use the intrinsicRow display instead of normal socket UI. It also treats exotic class items' intrinsic perks as non-reusable so that they don't get highlighted as selectable perks in the UI.
This also removes the stat display from class items in the item feed.
Desktop:
Mobile: