Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'enhanced' icon for enhanced weapons in place of 'shaped' icon #10670

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

FlaminSarge
Copy link
Contributor

@FlaminSarge FlaminSarge commented Aug 2, 2024

This affects the item's badge and the icon next to the crafted level on the item popup.

Fixes #10674

Screenshot 2024-08-02 at 4 40 18 PM Screenshot 2024-08-02 at 4 40 27 PM Screenshot 2024-08-02 at 5 56 32 PM

This affects the item's badge and the icon next to the crafted level on the item popup
@FlaminSarge
Copy link
Contributor Author

FlaminSarge commented Aug 2, 2024

I have no idea how to SVG. If there are existing assets out there for this those would be better.

Reference:

@bhollis
Copy link
Contributor

bhollis commented Aug 5, 2024

I don't know how enhancing weapons works (I haven't played enough to come across it). But what is it about enhanced weapons that users would need to see a special icon on the item tile? Do they show up differently in game?

@FlaminSarge
Copy link
Contributor Author

I don't know how enhancing weapons works (I haven't played enough to come across it). But what is it about enhanced weapons that users would need to see a special icon on the item tile? Do they show up differently in game?

Enhanced weapons have always shown up in-game with this diamond icon in the bottom left of the item badge (where we put the lock icon right now), rather than the square crafted icon, so it made sense to replicate that in DIM especially since it's so readily available from the API response.
image

With TFS launch, enhancing no longer requires going to the Enclave, where Crafted weapons still do (where prior to TFS both involved Enclave stuff), so the flow for enhancing weapons has diverged significantly from crafting them. If the UX for modifying these weapons was shared, then it may not make as much sense to distinguish them, but since they've diverged so much, it's probably better to keep them separate.

@bhollis bhollis merged commit 1fad30e into DestinyItemManager:master Aug 5, 2024
6 checks passed
@FlaminSarge FlaminSarge deleted the enhance branch August 6, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

change enhanced weapons' polaroid icon
2 participants