Use Organizer's table-sort logic in Compare #10702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhollis
commented
Aug 29, 2024
Comment on lines
+238
to
+240
| ? columnSort.sort === SortDirection.ASC | ||
| ? styles.sortDesc | ||
| : styles.sortAsc |
There was a problem hiding this comment.
This is a bit awkward but I'll clean it up later - the original styles were actually backwards between "ascending" and "descending".
bhollis
force-pushed
the
table-sorts-compare
branch
from
4169979
to
b7bf922
Compare
bhollis
force-pushed
the
table-sorts-compare
branch
from
37f591f
to
34de3f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces Compare's stat-sorting logic with the table sorter from Organizer. It should behave identically, with the one difference that it is now possible to shift-click a stat to sort by multiple stats at once.