Fix Sass mixed-declaration warning using stylelint-order #10707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhollis
force-pushed
the
sass-declaration-order
branch
from
799e72a
to
48ae00c
Compare
bhollis
changed the title
|
Sorry, just saw this request for review from me. Code looks good though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sass is complaining about a new breaking change affecting "mixed declarations" where declarations are mixed in before and after nested rules. I like this - I don't like it when there are declarations after nested rules.
https://sass-lang.com/documentation/breaking-changes/mixed-decls/
After a few minutes trying to fix these manually, I turned to the stylelint-order plugin and described a strict ordering for how things should appear in a block.