Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enhancementTier to craftedInfo and display it in weapon level bar #10713

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

FlaminSarge
Copy link
Contributor

@FlaminSarge FlaminSarge commented Sep 2, 2024

Fixes #10715

Screenshot 2024-09-02 at 6 05 16 AM

For reference, here's how Bungie displays this:
image

@FlaminSarge
Copy link
Contributor Author

FlaminSarge commented Sep 2, 2024

Alternatives considered:
I tried various ways of showing the tier number overlaid on top of the enhancement icon, but it was not very readable, and placing it in the weapon level bar was far more readable.
Screenshot 2024-09-02 at 6 18 51 AM

I tried using "Enhancement Tier N" instead of just "Tier N", but that ended up taking up too much space in the weapon level bar.
Screenshot 2024-09-02 at 6 11 01 AM

Copy link
Contributor

@bhollis bhollis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. I agree with your choice given the alternatives.

@FlaminSarge FlaminSarge merged commit 58fc02e into DestinyItemManager:master Sep 3, 2024
6 checks passed
@FlaminSarge FlaminSarge deleted the enhancement-tier branch September 3, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show enhancement tier in the crafting tooltip
2 participants