Better error handling for weird Bungie.net auth responses (no auth loops) #2058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleshay
approved these changes
Aug 3, 2017
There was a problem hiding this comment.
Nice! Is there anything we could do to help the user know how to fix the issue? Goose mentioned clearing the cache or something similar to fix?
Should consider eventually pulling out the strings for i18n /cc @delphiactual
|
Hard reload is the same as clearing the cache, so we're good there. Right now the auth return "app" doesn't have i18n set up at all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help us with "auth loops" when either Bungie.net or the user's browser is misbehaving. Instead of sending them directly back to the login page on missing code or state parameter, we'll display an error instead. It's not a very helpful error, but they'll at least have something to tell us.