Avoid caching the service worker #2059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our service worker doesn't work very well, because it's served with the same expiration rules as all the other JS - one year expiration. This changes it to never be cached, so new pageloads will always check for a new service worker (this is recommended: w3c/ServiceWorker#893). Unfortunately, to break the CloudFlare cache without waiting a year, I also needed to rename the file.
This should fix some cases where DIM loads as a blank white screen and requires a force-refresh to actually work.
I also added some text that gets blown away on app load, but will try to help a bit in cases where JavaScript is disabled or the scripts completely fail to load.