-
-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edit in-game identifiers for DIM loadouts #9760
Conversation
The size looks good — well balanced for what will essentially be the primary identifier when set. The header is starting to get a little cosy with all the icons — but it's not unusable imo. A potential idea for space-saving: only show the class icon when the loadout tray is opened via an external link or creating a new loadout. The thinking behind this being that in most cases the loadout tray is opened via the class menu or the selected class tile — so you'll always have that context. The downside is that conditional visibility of UI could get confusing. A more dramatic option could be to pull out the class icon and give it a label. This could allow contextual info to be shown when opening loadouts via a link i.e loadout doesn't match selected class (assuming this has value). |
Also - I can't remember how the loadout tray behaves when you open a loadout link for a class that you do not have a character for… I remember trying this and being annoyed that I couldn't open the link or something (when I just wanted to inspect the build). Just mentioning this as it might be another case (albeit fringe) that could benefit from showing class info more unambiguously in the loadout tray. |
We don't allow you to open a loadout link that can't be used by one of your characters, so it's probably OK. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'm not sure about the plus icon to edit loadout identifiers, but the game doesn't have a good icon to denote identifiers, so probably ok.
I'll probably end up having to do something different with how the loadout share works, because we don't auto-select the right class when opening a class-specific loadout. |
I'm leaving this one in limbo until I can get the "save as in-game loadout" button in. |
Merged under a disabled feature flag, just so this doesn't keep drifting out of date. |
This adds the ability to set an in-game identifier (name, color, icon) for a DIM loadout, with the intention that it's used as the default when copying the loadout to an in-game loadout. Fixes #9456. I may decide to feature flag this out until we actually have the ability to copy to an in-game loadout (which will require all kinds of extra UI and warnings and such) which in turn will have to wait until in-game loadouts are re-enabled.
I'm a bit worried that it takes up too much space on mobile, but I'm not sure where else to put it.