Slight redesign of accounts menu #9916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guise
approved these changes
Sep 25, 2023
There was a problem hiding this comment.
Long usernames are a bit more likely to increase the width of the nav drawer — I don't think that's an issue though, it still wraps fine on mobile.
Small suggestion: Add a <hr> above the accounts section if you want a clearer delineation between the main sections of the nav (modules/help/account)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized that the accounts being "dimmed" made them look disabled. I figured while I was in there I could make them the same size as the other menu items, and collapse the account info into the same line as the accounts header.
Also filtered out Stadia (unless it's the only account type) and sort the account's original platform type to the front.
Before:
After:
