Revert "Added exemption to the reportUnnecessaryComparison rule for…

… simple wildcard patterns in a `case` clause. This addresses #4706. (#9582)"

our exemption logic is better because it still reports the error if the wildcard case is not used to assert that it's unreachable

This reverts commit 9041f88

packages/pyright-internal/src/analyzer/patternMatching.ts

@@ -2225,16 +2225,6 @@ export function getPatternSubtypeNarrowingCallback(
 }
 
 function reportUnnecessaryPattern(evaluator: TypeEvaluator, pattern: PatternAtomNode, subjectType: Type): void {
-    // If this is a simple wildcard pattern, exempt it from this diagnostic.
-    if (
-        pattern.nodeType === ParseNodeType.PatternAs &&
-        pattern.d.orPatterns.length === 1 &&
-        pattern.d.orPatterns[0].nodeType === ParseNodeType.PatternCapture &&
-        pattern.d.orPatterns[0].d.isWildcard
-    ) {
-        return;
-    }
-
     evaluator.addDiagnostic(
         DiagnosticRule.reportUnnecessaryComparison,
         LocMessage.patternNeverMatches().format({ type: evaluator.printType(subjectType) }),

packages/pyright-internal/src/tests/samples/matchUnnecessary1.py

@@ -84,14 +84,3 @@ def func4(vals: list[str]) -> TA1:
             case _:
                 pass
     return x
-
-
-def func5(subj: int | str):
-    match subj:
-        case int() | str():
-            pass
-
-        # This should not generate a diagnostic becuase _ is exempted
-        # from the reportUnnecessaryComparison check.
-        case _:
-            pass