add None context manager test

DetachHead · Dec 19, 2024 · cbdd6d3 · cbdd6d3
1 parent ef1db72
commit cbdd6d3
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/packages/pyright-internal/src/tests/checker.test.ts b/packages/pyright-internal/src/tests/checker.test.ts
@@ -172,7 +172,12 @@ test('With2', () => {
 
 test('context manager where __exit__ returns bool | None', () => {
     const analysisResults = TestUtils.typeAnalyzeSampleFiles(['withBased.py']);
-    TestUtils.validateResultsButBased(analysisResults, { unreachableCodes: [{ line: 47 }], unusedCodes: undefined });
+    TestUtils.validateResultsButBased(analysisResults, {
+        hints: [
+            { code: DiagnosticRule.reportUnreachable, line: 45 },
+            { code: DiagnosticRule.reportUnreachable, line: 60 },
+        ],
+    });
 });
 
 test('With3', () => {

diff --git a/packages/pyright-internal/src/tests/samples/withBased.py b/packages/pyright-internal/src/tests/samples/withBased.py
@@ -1,8 +1,6 @@
 import contextlib
 from types import TracebackType
-from typing import Iterator, Literal
-
-from typing_extensions import assert_never
+from typing import Literal
 
 class BoolOrNone(contextlib.AbstractContextManager[None]):
     def __exit__(
@@ -45,4 +43,19 @@ def __exit__(
 def _():
     with FalseOrNone():
         raise Exception
+    print(1)  # unreachable
+
+
+class OnlyNone(contextlib.AbstractContextManager[None]):
+    def __exit__(
+        self,
+        __exc_type: type[BaseException] | None,
+        __exc_value: BaseException | None,
+        __traceback: TracebackType | None,
+    ) -> None:
+        ...
+
+def _():
+    with OnlyNone():
+        raise Exception
     print(1)  # unreachable