fix reportUnusedParameter false positive on abstract setters
#956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DetachHead
force-pushed
the
fix-reportunusedparameter-false-positive
branch
from
977887c to
ab092fa
Compare
|
Diff from mypy_primer, showing the effect of this PR on open source code: sympy (https://github.com/sympy/sympy)
- Type of "i" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "i" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "rootof" is "(f: Unknown, x: Unknown, index: Unknown | None = None, radicals: bool = True, expand: bool = True) -> (Unknown | One | NegativeOne | Zero | Integer | Rational | NaN | ComplexInfinity | Half | Expr)" (reportUnknownVariableType)
+ Type of "rootof" is "(f: Unknown, x: Unknown, index: Unknown | None = None, radicals: bool = True, expand: bool = True) -> (Unknown | One | NegativeOne | Zero | Integer | Rational | NaN | ComplexInfinity | Half | Infinity | NegativeInfinity | Float | _NotImplementedType | Expr)" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_inequalities.py:134:9 - warning: Type of "inf" is partially unknown
- Type of "inf" is "One | NegativeOne | Zero | Integer | Rational | NaN | ComplexInfinity | Half | Unknown" (reportUnknownVariableType)
- Argument type is "Equality | Unknown | Relational | Unequality" (reportUnknownArgumentType)
+ Argument type is "Equality | Unknown" (reportUnknownArgumentType)
- Argument type is "Equality | Unknown | Relational | Unequality" (reportUnknownArgumentType)
+ Argument type is "Equality | Unknown" (reportUnknownArgumentType)
- Type of "e" is "Equality | Unknown | Relational | Unequality | NaN | Sum" (reportUnknownVariableType)
+ Type of "e" is "Equality | Unknown | NaN | Sum" (reportUnknownVariableType)
- Argument type is "Equality | Unknown | Relational | Unequality" (reportUnknownArgumentType)
+ Argument type is "Equality | Unknown" (reportUnknownArgumentType)
- Argument type is "Equality | Unknown | Relational | Unequality" (reportUnknownArgumentType)
+ Argument type is "Equality | Unknown" (reportUnknownArgumentType)
- Argument type is "Equality | Unknown | Relational | Unequality" (reportUnknownArgumentType)
+ Argument type is "Equality | Unknown" (reportUnknownArgumentType)
- Argument type is "Equality | Unknown | Relational | Unequality" (reportUnknownArgumentType)
+ Argument type is "Equality | Unknown" (reportUnknownArgumentType)
- Type of "r" is "Unknown | One | NegativeOne | Zero | Integer | Rational | NaN | ComplexInfinity | Half | Expr" (reportUnknownVariableType)
+ Type of "r" is "Unknown | One | NegativeOne | Zero | Integer | Rational | NaN | ComplexInfinity | Half | Infinity | NegativeInfinity | Float | _NotImplementedType | Expr" (reportUnknownVariableType)
- Type of "ie" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "ie" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "e" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "e" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "eq" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "eq" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "eq" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "eq" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "eq" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "eq" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "wave" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "wave" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "eq" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "eq" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "eq" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "eq" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "sol4" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "sol4" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "expand" is "((**kwargs: Unknown) -> Equality) | Unknown | ((**kwargs: Unknown) -> Relational) | ((**kwargs: Unknown) -> Unequality)" (reportUnknownMemberType)
+ Type of "expand" is "((**kwargs: Unknown) -> Equality) | Unknown" (reportUnknownMemberType)
- Type of "expand" is "((**kwargs: Unknown) -> Equality) | Unknown | ((**kwargs: Unknown) -> Relational) | ((**kwargs: Unknown) -> Unequality)" (reportUnknownMemberType)
+ Type of "expand" is "((**kwargs: Unknown) -> Equality) | Unknown" (reportUnknownMemberType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_recurr.py:116:5 - warning: Type of "h" is unknown (reportUnknownVariableType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_recurr.py:116:5 - warning: Type of "h" is Any (reportAny)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:104:9 - warning: Return type, "tuple[int, list[_NotImplementedType | Unknown | Any | GreaterThan | Equality | Relational | Unequality], Any]", is partially unknown (reportUnknownParameterType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:104:9 - warning: Return type, "tuple[int, list[_NotImplementedType | Unknown | Any | GreaterThan | Equality | Relational | Unequality | LessThan | bool], Any]", is partially unknown (reportUnknownParameterType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:105:13 - warning: Return type, "Integer | Unknown | NaN | Expr | One | NegativeOne | Zero | Rational | ComplexInfinity | Half", is partially unknown (reportUnknownParameterType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:109:20 - warning: Return type, "Unknown | NaN | Expr | One | NegativeOne | Zero | Integer | Rational | ComplexInfinity | Half", is partially unknown (reportUnknownVariableType)
- Type of "constraints" is "list[_NotImplementedType | Unknown | Any | GreaterThan | Equality | Relational | Unequality]" (reportUnknownVariableType)
+ Type of "constraints" is "list[_NotImplementedType | Unknown | Any | GreaterThan | Equality | Relational | Unequality | LessThan | bool]" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:111:29 - warning: Argument type is partially unknown
- Argument corresponds to parameter "iterable" in function "sum"
- Argument type is "Generator[Any | Unknown, None, None]" (reportUnknownArgumentType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:113:25 - warning: Argument type is partially unknown
- Argument corresponds to parameter "iterable" in function "sum"
- Argument type is "Generator[Any | Unknown, None, None]" (reportUnknownArgumentType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:114:16 - warning: Return type, "tuple[int, list[_NotImplementedType | Unknown | Any | GreaterThan | Equality | Relational | Unequality], Any]", is partially unknown (reportUnknownVariableType)
+ /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:114:16 - warning: Return type, "tuple[int, list[_NotImplementedType | Unknown | Any | GreaterThan | Equality | Relational | Unequality | LessThan | bool], Any]", is partially unknown (reportUnknownVariableType)
- Type of "r1" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "r1" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "r2" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "r2" is "Equality | Unknown" (reportUnknownVariableType)
- Type of "constraints" is "list[Equality | Unknown | Relational | Unequality | Any]" (reportUnknownVariableType)
+ Type of "constraints" is "list[Equality | Unknown | Any]" (reportUnknownVariableType)
- Type of "constr" is "Equality | Unknown | Relational | Unequality | Any" (reportUnknownVariableType)
+ Type of "constr" is "Equality | Unknown | Any" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:181:5 - warning: Type of "ans" is partially unknown
- Type of "ans" is "tuple[Unknown, list[int | Unknown]]" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:221:9 - warning: Type of "ans" is partially unknown
- Type of "ans" is "tuple[Unknown, list[int | Unknown]]" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:222:48 - warning: Argument type is partially unknown
- Argument corresponds to parameter "iterable" in function "__init__"
- Argument type is "zip[tuple[Any, int | Unknown]]" (reportUnknownArgumentType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:222:55 - warning: Argument type is partially unknown
- Argument corresponds to parameter "iter2" in function "__new__"
- Argument type is "list[int | Unknown]" (reportUnknownArgumentType)
- Type of "eq" is "list[Equality | Unknown | Relational | Unequality]" (reportUnknownVariableType)
+ Type of "eq" is "list[Equality | Unknown]" (reportUnknownVariableType)
- Type of "i" is "Equality | Unknown | Relational | Unequality" (reportUnknownVariableType)
+ Type of "i" is "Equality | Unknown" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:229:9 - warning: Type of "ans" is partially unknown
- Type of "ans" is "tuple[Unknown, list[int | Unknown]]" (reportUnknownVariableType)
- /tmp/mypy_primer/projects/sympy/sympy/solvers/tests/test_simplex.py:230:53 - warning: Argument type is partially unknown
- Argument corresponds to parameter "iterable" in function "__init__"
- Argument type is "zip[tuple[Any, int | Unknown]]" (reportUnknownArgumentType)
... (truncated 2743 lines) ...
pip (https://github.com/pypa/pip)
- /tmp/mypy_primer/projects/pip/src/pip/_vendor/packaging/specifiers.py:77:27 - warning: "value" is not accessed (reportUnusedParameter)
- 2394 errors, 38189 warnings, 0 notes
+ 2394 errors, 38188 warnings, 0 notes
packaging (https://github.com/pypa/packaging)
- /tmp/mypy_primer/projects/packaging/src/packaging/specifiers.py:77:27 - warning: "value" is not accessed (reportUnusedParameter)
- 34 errors, 281 warnings, 0 notes
+ 34 errors, 280 warnings, 0 notes
vision (https://github.com/pytorch/vision): 1.55x slower (42.4s -> 65.6s in a single noisy sample)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #605