handle local files via protocol file:/ in http
#113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Neat! this should fix #90 ! |
|
no wait that issue still needs further look into, this just takes care of file:/ protocol and handles non-ASCII paths |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
recently mods for source-engine based games started to use
ISteamHttpto get/download the localpreview_filepath(path to the mod preview image).behavior changes:
forward slashes at the end of the url '/' are no longer saved in
index.html, the website name will always be the target file.example: response of
wwww.example.com/will be saved in the filewwww.example.comrather thanwwww.example.com/index.html.this was pretty inconsistent for me since games do not always add or ommit that forward slash, plus it makes the path shorter, avoiding the trouble on Windows.