Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate_emu_config: Fix credentials #75

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Conversation

detiam
Copy link
Contributor

@detiam detiam commented Oct 31, 2024

so no need to enter 2fa code every time and no need to save password in a plaintext file.

@DogancanYr
Copy link
Contributor

You can put the username and password in the txt file and use it continuously.
What's the difference?

@Sak32009
Copy link
Contributor

Sak32009 commented Nov 1, 2024

I strongly advise against storing sensitive data in plain text.

@detiam
Copy link
Contributor Author

detiam commented Nov 1, 2024

You can put the username and password in the txt file and use it continuously. What's the difference?

If 2fa/email code is enabled you need to enter it every login, with this you can skip it, even login without password, like real steam. And this is already in generate_emu_config, I just fixed it.

I strongly advise against storing sensitive data in plain text.

This token itself is encrypted, better than plain text password.

@Sak32009
Copy link
Contributor

Sak32009 commented Nov 1, 2024

Of course, but if that token is exposed, it could be exploited.

@DogancanYr
Copy link
Contributor

If 2fa/email code is enabled you need to enter it every login, with this you can skip it, even login without password, like real steam. And this is already in generate_emu_config, I just fixed it.

I didn't understand this sentence. "save password in a plaintext file." Did you mean token?

@detiam
Copy link
Contributor Author

detiam commented Nov 1, 2024

I didn't understand this sentence. "save password in a plaintext file." Did you mean token?

oh I mean "... and no need to save password in a plaintext file.", missing a bit, sorry 😅

@detiam
Copy link
Contributor Author

detiam commented Nov 1, 2024

Of course, but if that token is exposed, it could be exploited.

I added a switch to prevent saving token to disk.

@alex47exe
Copy link

Really cool idea. Mind if I integrate it in generate_emu_config on my gse_fork?

@detiam
Copy link
Contributor Author

detiam commented Nov 4, 2024

Really cool idea. Mind if I integrate it in generate_emu_config on my gse_fork?

No, feel free to :-)

@Detanup01
Copy link
Owner

Shouldnt saving into disk would be opt-in not the saving on disk to be opt-out?

@detiam
Copy link
Contributor Author

detiam commented Nov 5, 2024

Shouldnt saving into disk would be opt-in not the saving on disk to be opt-out?

Ok, updated

@Detanup01
Copy link
Owner

Neat, thanks!

@Detanup01 Detanup01 merged commit ecea684 into Detanup01:dev Nov 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants