Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import version from package.json directly #17

Merged
merged 8 commits into from
Apr 20, 2024

Conversation

lucperkins
Copy link
Member

@lucperkins lucperkins commented Apr 20, 2024

This PR removes the file copying logic in #16 and replaces it with a new build process that compiles the package version directly into the output JS:

❯ cat dist/index.cjs | grep "1.0.0" | wc -l
1

I've also renamed main.ts to index.ts because main suggests that the core logic is runnable.

Copy link

netlify bot commented Apr 20, 2024

Deploy Preview for detsys-ts-docs ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/detsys-ts-docs/deploys/6623f490710073eeb0914701
😎 Deploy Preview https://deploy-preview-17--detsys-ts-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lucperkins lucperkins changed the base branch from main to uuid-cleanup April 20, 2024 15:07
@lucperkins lucperkins requested a review from grahamc April 20, 2024 15:50
@lucperkins lucperkins merged commit 529a09a into uuid-cleanup Apr 20, 2024
1 check passed
@lucperkins lucperkins deleted the direct-import-package-json branch April 20, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant