-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collect backtraces for segfaults and whatnot #58
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for detsys-ts-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lucperkins
requested changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nits
lucperkins
approved these changes
Aug 26, 2024
grahamc
had a problem deploying
to
detsys-pr-bot
August 26, 2024 13:29 — with
GitHub Actions
Failure
grahamc
had a problem deploying
to
detsys-pr-bot
August 26, 2024 13:30 — with
GitHub Actions
Failure
This was referenced Aug 26, 2024
grahamc
had a problem deploying
to
detsys-pr-bot
August 26, 2024 13:35 — with
GitHub Actions
Failure
grahamc
had a problem deploying
to
detsys-pr-bot
August 26, 2024 13:35 — with
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note the default GitHub Actions runner for Linux uses apport, which doesn't make it easy to get crash dumps / back traces. The macOS codepath works perfectly, and the systemd flow works correctly if the host has systemd-coredump installed. If it doesn't, no error is raised.
Checklist