Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix environment variable name for flake visibility #125

Merged
merged 7 commits into from
Apr 24, 2024
Merged

Fix environment variable name for flake visibility #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a273a28
Fix environment variable name for flake visibility
lucperkins Apr 21, 2024
4c1d0d1
Merge remote-tracking branch 'origin/main' into fix-env-var-name
lucperkins Apr 21, 2024
403d34d
Support both spellings of the var name
lucperkins Apr 21, 2024
9515a02
Fix merge conflicts with main
lucperkins Apr 24, 2024
2bd1efc
Make both visibility settings Options
lucperkins Apr 24, 2024
1bafd43
Add missing period in log message
lucperkins Apr 24, 2024
d70933e
Reinstate commented-out TS
lucperkins Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94311,6 +94311,7 @@ var FlakeHubPushAction = class {
}
executionEnvironment() {
const env = {};
env.FLAKEHUB_PUSH_VISIBILITY = this.visibility;
env.FLAKEHUB_PUSH_TAG = this.tag;
env.FLAKEHUB_PUSH_HOST = this.host;
env.FLAKEHUB_PUSH_LOG_DIRECTIVES = this.logDirectives;
Expand Down Expand Up @@ -94339,19 +94340,13 @@ var FlakeHubPushAction = class {
core.debug(
`execution environment: ${JSON.stringify(executionEnv, null, 2)}`
);
const exitCode = await exec.exec(
binary,
// We're setting this via flag for now due to a misspelling in the original environment variable.
// Remove this in favor of the environment variable only after PR #125 is merged.
["--visibility", this.visibility],
{
env: {
...executionEnv,
...process.env
// To get PATH, etc.
}
const exitCode = await exec.exec(binary, [], {
env: {
...executionEnv,
...process.env
// To get PATH, etc.
}
);
});
if (exitCode !== 0) {
this.idslib.recordEvent(EVENT_EXECUTION_FAILURE, {
exitCode
Expand Down
2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading