Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace rxjs of import #95

Closed
1 of 4 tasks
gkaran opened this issue Apr 26, 2018 · 0 comments
Closed
1 of 4 tasks

Replace rxjs of import #95

gkaran opened this issue Apr 26, 2018 · 0 comments

Comments

@gkaran
Copy link
Contributor

gkaran commented Apr 26, 2018

Summary

I'm submitting a:

  • bug report
  • feature request
  • question / support request
  • other

Description

Avoid monkey patching rxjs operators. Instead of

import 'rxjs/add/observable/of';

the new import style should be used:

import { of } from 'rxjs/observable/of';
gkaran added a commit to gkaran/ng-recaptcha that referenced this issue Apr 26, 2018
@gkaran
chore(rxjs): change import of of operator
df62298 
Use the pipeable import for `of` operator instead
of the monkey patching one.

Closes DethAriel#95
@gkaran gkaran mentioned this issue Apr 26, 2018
Merged
DethAriel pushed a commit that referenced this issue Apr 27, 2018
@gkaran @DethAriel
chore(rxjs): change import of of operator
388863b 
Use the pipeable import for `of` operator instead
of the monkey patching one.

Closes #95
DethAriel pushed a commit that referenced this issue Apr 27, 2018
@gkaran @DethAriel
fix(rxjs): change import of of operator
3e0bda6 
Use the pipeable import for `of` operator instead
of the monkey patching one.

Closes #95
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gkaran